search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

CT: Duplicate test specified in listContinuousTests #263

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

This has been failing since at least 3/9/2022, the oldest cycle currently shown in CT.

It looks like @zepumph introduced a duplicate entry on 3/8/2022 in https://github.com/phetsims/perennial/commit/3ded4e39c428a206f5cfcd60ce0e2853ca89c521 for https://github.com/phetsims/scenery/issues/1373. I see 2 entries in listContinuousTests.js for 'phet-io-input-record-and-playback-fuzz'.

perennial : listContinuousTests
Duplicate test specified in listContinuousTests: arithmetic.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: balancing-act.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: balloons-and-static-electricity.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: beers-law-lab.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: bending-light.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: blackbody-spectrum.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: build-an-atom.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: bumper.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: buoyancy.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: capacitor-lab-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: center-and-spread.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: chains.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: charges-and-fields.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: circuit-construction-kit-ac.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: circuit-construction-kit-dc.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: color-vision.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: concentration.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: coulombs-law.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: density.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: diffusion.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: energy-forms-and-changes.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: energy-skate-park.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: energy-skate-park-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: faradays-law.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: forces-and-motion-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: fourier-making-waves.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: friction.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: gas-properties.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: gases-intro.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: geometric-optics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: geometric-optics-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: graphing-quadratics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: gravity-and-orbits.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: gravity-force-lab.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: gravity-force-lab-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: greenhouse-effect.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: hookes-law.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: john-travoltage.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: molarity.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: molecule-polarity.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: molecule-shapes.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: molecule-shapes-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: molecules-and-light.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: natural-selection.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: ohms-law.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: ph-scale.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: ph-scale-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: phet-io-test-sim.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: projectile-motion.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: proportion-playground.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: quadrilateral.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: ratio-and-proportion.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: resistance-in-a-wire.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: states-of-matter.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: states-of-matter-basics.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: sun.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: wave-on-a-string.phet-io-input-record-and-playback-fuzz.unbuilt
Duplicate test specified in listContinuousTests: wilder.phet-io-input-record-and-playback-fuzz.unbuilt

Snapshot from 3/10/2022, 10:55:36 AM
pixelzoom commented 2 years ago

I was going to just delete one of these tests. But on closer inspection, they have different query parameters:

185 url: `phet-io-wrappers/input-record-and-playback/?sim=${repo}&phetioDebug&fuzz`,

192 url: `phet-io-wrappers/input-record-and-playback/?sim=${repo}&phetioDebug&fuzzBoard`,

I'm guessing that the intention was to add an additonal test for keyboard fuzzing (fuzzBoard), and that the test name needs to be changed so that it's unique. But I'll let @zepumph decide what he intended here.

zepumph commented 2 years ago

Yea thanks. I didn't change the test name.