search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

Email notification failed from build-server #265

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

I deployed geometric-optics 1.1.0-rc.1 today. The deployed files look correct. But I never received an email confirmation. Here's the log (XXXXXX is a potential password that I've redacted.)

% ssh -l malleyc phet-server2.int.colorado.edu
% sudo journalctl -u build-server -f
...
info: build for geometric-optics finished successfully
Mar 18 14:42:29 phet-server2.int.colorado.edu build-server[886175]: info: attempting to send email
Mar 18 14:42:30 phet-server2.int.colorado.edu build-server[886175]: error: error when attempted to send email, err = Error: authorization.failed (bad response on command 'XXXXXX': #5.7.0 Authentication failed)
zepumph commented 2 years ago

(bad response on command 'XXXXXX': #5.7.0 Authentication failed)

@pixelzoom and I think the XXXXXX part may be a password. If this is the case @mattpen, could we get that out of the log in the future?

mattpen commented 2 years ago

I updated the password for the build-server in build-local.json, and pushed a commit which contains a filter for the password string on the email error logger.

mattpen commented 2 years ago

I think both issues should be fixed, the bad email password and the logging of the password in plain text. The logs with the old password were deleted upon the last log rotation. I successfully ran an RC and production deploy for chains to test. Closing.