search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

hook-pre-commit.js does not print tsc errors by default #277

Closed jessegreenberg closed 2 years ago

jessegreenberg commented 2 years ago

tsc errors are only printed if outputToConsole is true.

https://github.com/phetsims/perennial/blob/master/js/scripts/hook-pre-commit.js#L101-L107

Would it be OK if we always print tsc errors? hook-pre-commit.js always reports lint errors so I had expected tsc errors to always be reported as well. Without printing I had thought that hook-pre-commit.js was failing silently somewhere. If there is a failure to commit it is nice to be told where it is without needing to run tsc again.

jessegreenberg commented 2 years ago

I removed the outputToConsole check so it always prints if there is error. @samreid are you OK with this?

samreid commented 2 years ago

Excellent, thanks! Closing.