search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
3 stars 5 forks source link

CT Lint-everything failed with status code 1: #280

Closed KatieWoe closed 2 years ago

KatieWoe commented 2 years ago 
perennial : lint-everything
Lint-everything failed with status code 1:
Running "lint-everything" task

/data/share/phet/continuous-testing/ct-snapshots/1660558781438/aqua/js/patient-snapshotter.ts
57:1 error Missing return type explicit-method-return-type
61:1 error Missing return type explicit-method-return-type
88:1 error Missing return type explicit-method-return-type
110:1 error Missing return type explicit-method-return-type
116:1 error Missing return type explicit-method-return-type
124:1 error Missing return type explicit-method-return-type

✖ 6 problems (6 errors, 0 warnings)
5 errors and 0 warnings potentially fixable with the `--fix` option.

Fatal error: Lint failed
Snapshot from 8/15/2022, 4:19:41 AM
mattpen commented 2 years ago

I'm not sure what I can do to help here. @jonathanolson please let me know if you need anything from me.

KatieWoe commented 2 years ago 
perennial : lint-everything
Lint-everything failed with status code 1:
Running "lint-everything" task

/data/share/phet/continuous-testing/ct-snapshots/1662699095940/rosetta/js/stringSubmissionQueue.js
21:7 error 'SEND_BUILD_REQUESTS' is assigned a value but never used no-unused-vars

✖ 1 problem (1 error, 0 warnings)

Fatal error: Lint failed
Snapshot from 9/8/2022, 10:51:35 PM
jonathanolson commented 2 years ago

I believe @jbphet fixed this lint error with https://github.com/phetsims/rosetta/commit/37ac1ae8ac641dbb97153d70e087de41c2c82249, closing!