search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

Issues with daily-grunt-work and pre-commit hooks #285

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

I don't believe that daily-grunt-work should run pre-commit hooks. It leads to working copy changes in the repos.

zepumph commented 1 year ago

I checked in with the daily grunt work again today and things are looking much better. One of the keys was to pull again before pushing at the end, just in case. Also I found that the babel updates needed more than a commit -am if they are a newly created file. So I am manually adding everything from that generated directory.

zepumph commented 1 year ago

Looking much better! But babel still didn't push, so I updated the ending script just in case a translation comes in between runnings.

zepumph commented 1 year ago

Last night was looking pretty good, but binder messed some things up last night.

zepumph commented 1 year ago

I just say great things from a wonderful run. After a week status is still good, and runs happen every night. Closing