phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
3 stars 5 forks source link

Adding branch protection changes to a fix process #306

Closed jonathanolson closed 1 year ago

jonathanolson commented 1 year ago

@jessegreenberg can you review the incoming commit on this issue? I'm curious if this will cause issues (it seems to do the job properly).

jonathanolson commented 1 year ago

Also, perhaps they should live in a common place if so? githubProtectBranches could also potentially expose more functionality to the outside than just a single function.

jessegreenberg commented 1 year ago

fixDivergedReleaseBranch looks very nice - good documentation and code is easy to read. I exported a new function to clear branch protections for repos, protectGithubBranches.js exports protectBranches() and clearBranchProtections() now if that is helpful.

But using octokit here is also fine and I can't think of any problems with this.

jonathanolson commented 1 year ago

Sounds good, thanks!