Open chrisklus opened 1 year ago
May be related to or a duplicate of https://github.com/phetsims/perennial/issues/223
After the above commit, when I add a working copy change to utterance-queue and grunt grunt dev, I get this error:
mjkauzmann ~/PHET/git/my-solar-system (master)
$ grunt dev --brands=phet
Running "dev" task
(Forwarding task to perennial)
Running "dev" task
info: getting dependencies.json for my-solar-system
Fatal error: Perennial task failed:
Error: Unclean status in utterance-queue, cannot deploy
at module.exports (C:\Users\mjkauzmann\PHET\git\perennial\js\grunt\dev.js:78:13)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async C:\Users\mjkauzmann\PHET\git\perennial\js\grunt\Gruntfile.js:380:7
at async wrap (C:\Users\mjkauzmann\PHET\git\perennial\js\grunt\Gruntfile.js:44:7)
Full Error details:
Error: Unclean status in utterance-queue, cannot deploy
Fatal error: perennial grunt "--repo=my-solar-system" "dev" "--brands=phet" failed with code 1
@chrisklus please take a look and see what you think. Is there any worry that this is overstepping?
[ ] I wonder if we should factor this out for use in:
createRelease
createOneOff
production
rc
wrapper
While creating a new dev version, I accidentally forgot to revert some changes in a dependency repo, and so they were incorrectly included in the dev version. This was not caught because the deployment process only checks if the repo being deployed has a clean git status, not its dependencies, as @zepumph discovered when looking at
gitIsClean
. It was expressed on Slack that it seems incorrect to be able to create a dependencies.json without valid shas. The same check is used in rc.js and production.js, so the problem could be happening there too but it's unclear to me if those are verifying shas some other way.Slack thread: