search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

SimVersion should accept number or string #315

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

@marlitas and I found over in https://github.com/phetsims/phet-io/issues/1869 that the metadata service gives version numbers in strings, but SimVersion expects numbers. It would be a nice and small improvement to update this by parsing the non numbers into numbers in the constructor.

zepumph commented 1 year ago

Ok. This has been completed, and I did some extra support for having qunit tests in perennial. Closing