Closed zepumph closed 11 months ago
https://github.com/phetsims/perennial/commit/3b46d4d0e6e841cc522445e663cbdf644473bce1 fixed this bug as far as we can tell by testing on ox-dev. We kicked off chains deploy after making an RC, and confirmed it didn't push the RC changes to production. I just pulled the changes onto the production build-server and all seems good. I published chains 1.44 to production on the main production build-server. I think we are ready to close, and I will do a bit of damage searching on the phet-io side over in https://github.com/phetsims/special-ops/issues/249.
@jonathanolson, is there anything else here?
Notes while implementing:
Looks good to me!
@jonathanolson @samreid @jbphet and I found a bug where production versions of phet and phet-io brand sims have rc test version.
For example https://phet.colorado.edu/sims/html/calculus-grapher/1.0.3/calculus-grapher_all.html points to 1.0.4-rc.1.
This is since parallel checkouts on the build server in https://github.com/phetsims/chipper/issues/1112
Also tagging https://github.com/phetsims/perennial/issues/332
We should outfit ReleaseBranch.updateCheckout() to support provided dependencies.