Open marlitas opened 8 months ago
What do you recommend here? This is exactly what I would also expect in this case. It is also a classic gotcha that the new maintenance release tooling helps to prevent.
@mattpen recommended I open this issue, so I'm not sure... If that's how it's supposed to work, sounds good to me! @mattpen any follow up?
I would expect that grunt rc would detect that there are unpushed shas and fail before requesting that the build server attempt a build. I thought it was unexpected that the grunt rc would succeed when there are local commits on a dependency that have not been pushed.
For an RC deployment the grunt process did not recognize that a SHA had not been pushed up to the remote and went through to the build process which subsequently failed.
Steps to reproduce:
grunt rc --brands=phet --branch={{BRANCH}}
I was able to test the build locally, but received a build failure email after it tried to deploy.