search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

release-branch checkouts should include perennial/ #342

Closed zepumph closed 1 week ago

zepumph commented 8 months ago

While working on https://github.com/phetsims/phet-io/issues/1974, I'm finding it pretty hard to navigate through those sub-directories because most grunt commands I want to use only work with perennial, and not with perennial-alias. I'd love to add perennial to the list that gets checked out per directory. I don't foresee trouble here because our sims are working great only relying on perennial-alias.

zepumph commented 8 months ago

@jonathanolson does this seem ok to you? I didn't seem like much of an overhead, as I didn't tell it to npm install. Close if all is well with you.

jonathanolson commented 1 month ago

I'm not sure I agree with duplicating options in https://github.com/phetsims/perennial/commit/9b0155cceb0b5c6cf76573a6df14978022791a1a, that seems confusing to me. Why was --branch added?

jonathanolson commented 1 month ago

https://github.com/phetsims/perennial/commit/94723d2cf045a9731b3358a17bbab789c2d1a380

This seems like a good start, but it is NOT pulling it (!), so it will leave it in a very old state. Additionally it isn't npm updating it, so it isn't ready to be used. (That npm update might suck up a lot of time if we do that).

It doesn't seem like something I'd use, but if we're cloning it we should update it (like the other repos). Fine to leave with no NPM install.

zepumph commented 1 week ago

I'm not sure I agree with duplicating options in 9b0155c, that seems confusing to me. Why was --branch added?

It was probably the 50th time I had typed --branch instead of --target for grunt checkout-target. All other perennial grunt commands use --branch (rc,dev, etc) and so I'm quite used to that option. I can revert if you care strongly.

zepumph commented 1 week ago

Pulling it now. Thanks for the note. I too would like too keep npm updates out of this for time/speed. Having the repo available makes it easy to update manually when needed. Not need for it to be perfectly up to date all the time.

jonathanolson commented 1 week ago

I can revert if you care strongly.

Makes sense, let's leave it.

The pull above looks good, closing!