search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
MIT License
2 stars 5 forks source link

parameter order mismatch for `Maintenance.addNeededPatch()` #346

Open zepumph opened 8 months ago

zepumph commented 8 months ago

I like basing all parameter order from addNeededPatches, which is very clean: addNeededPatches( patchName, filter ). Having the patchName as the first parameter is very clear and relates nicely to the name of the function.

For these functions, I recommend doing the same, where the patchName is first (I'll paste the current parameter order):

addNeededPatchReleaseBranch( releaseBranch, patchName )
addNeededPatch( repo, branch, patchName )
removeNeededPatch( repo, branch, patchName )

Can I make the above have patchName as the first parameter? If so, what would need to change besides documentation/usages?