Closed zepumph closed 7 months ago
On hold until https://github.com/phetsims/phetcommon/issues/63 is MR'd.
I found one to work on:
C:\Users\mjkauzmann\PHET\2git\release-branches\number-line-integers-1.2\number-line-common\js\view\FillableBackgroundNode.ts
0:0 error Parsing error: ESLint was configured to run on `C:\Users\mjkauzmann\PHET\2git\release-branches\number-line-integers-1.2\number-line-common\js\view\FillableBackgroundNode.ts` using `parserOptions.project`: <tsconfigRootDir>/tsconfig\all\tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
✖ 1 problem (1 error, 0 warnings)
This is because all/tsconfig doesn't include number-line-common
.
The above problem was the only other one discovered:
Ok, the number-line-integers lint fix was pushed and deployed over in https://github.com/phetsims/number-line-integers/issues/132.
I'm tempted to use ReleaseBranch which is already doing something quite similar to this, but outfitting it for main
, and to use phetLibs instead of what is in the checked in dependencies.json. I'll see how it goes.
- [ ] All that is left here is to come up with a way to test this from main so we know when this problem occurs eagerly.
To be done in https://github.com/phetsims/aqua/issues/202.
From conversation with @jonathanolson in https://github.com/phetsims/phetcommon/issues/63. We know that lint is working on all release branches as of 2 months ago because of an MR on all sims. The Maintenance tooling runs perennial's
grunt rc
task, which lints. But what we don't know if we support is linting with only dependencies checked out. We found one error in my PhET-iO Hydrogen MR in https://github.com/phetsims/phetcommon/issues/63. There may be more, the path to test is is:That will hit everything, check it out, built it, and lint it.
Good luck us!