Closed Luisav1 closed 5 months ago
So to recap, the MR process has a hard error when trying to cherry pick a sha from sun into scenery. I believe this kind of error should be graceful. It is likely quite easy to reproduce. I'll take a look.
Ok. I added an extra step to check on if the sha exists. It gives an error like this now if we make this mistake again (which I have definitely done).
Error: Failure applying patch chipper to area-model-algebra 1.2: Error: SHA not in chipper: 888641be39cd75bfdb87784ea360df28d216d472
at Maintenance.applyPatches (C:\Users\mjkauzmann\PHET\git\perennial\js\common\Maintenance.js:801:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Anything else here @Luisav1?
@zepumph Nope, that was all! Closing.
When trying to apply a patch from scenery to AM sims, it resulted in the error below. I expected full error details but the cursor just remained blinking and the maintenance REPL prompt didn't reappear again. @zepumph said this should not happen and it should have a clean exit process and/or error details.
Based on the lack of error details @zepumph, suggested to try applying the commit before this one however that also resulted in the same error below for the earlier commit.