search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
http://scenerystack.org/
MIT License
4 stars 5 forks source link

document or delete build-for-server #409

Open samreid opened 3 days ago

samreid commented 3 days ago

During https://github.com/phetsims/perennial/issues/375 I saw a task build-for-server that calls build. It is not documented why we need an alias. The build server has this code:

    if ( buildForServer ) {
      args.push( 'build-for-server' );
    }
    else {
      args.push( 'build' );
    }

which also does not explain the need for build-for-server. Can it be documented or deleted?

zepumph commented 3 days ago

I couldn't find much about it. Seems to only be applied for chipper 1.0 sims. I would be careful about deleting something in this area, as it could be used exclusively for older versions of chipper.

zepumph commented 3 days ago

I see this in a chipper 1.0 release branch. In this case it is bending light 1.1 on chipper@2c6d5338a8b5b3668f6863d26e260fd353542fbb:

  grunt.registerTask( 'build-for-server', 'meant for use by build-server only',
    [ 'build', 'generate-thumbnails', 'generate-twitter-card' ]
  );

Seems best to not touch it.

zepumph commented 3 days ago

I'll Update doc.