search

phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
http://scenerystack.org/
MIT License
5 stars 5 forks source link

Create browser-and-node config #418

Open zepumph opened 6 days ago

zepumph commented 6 days ago

From https://github.com/phetsims/chipper/issues/1526#issuecomment-2501854917, we have a collection of es modules that we are using in both sims and Node code:

SimVersion
affirm()
phetioCompareAPIs

I'm creating a side issue from https://github.com/phetsims/chipper/issues/1526#issuecomment-2501854917. I also want to put this on hold until we complete https://github.com/phetsims/chipper/issues/1483

zepumph commented 6 days ago

I was able to confirm that this is what the browser-and-node tsconfig file should be (none of the browser-specific or node-specific config entries should be combined).

{
  "extends": "./tsconfig-core.json",
  "include": [
    "../js/browser-and-node/**/*"
  ]
}
zepumph commented 1 hour ago

I believe this is complete, but I'll come back once we complete https://github.com/phetsims/chipper/issues/1483/.

zepumph commented 17 minutes ago

Ok. I don't think there is anything else here. I'd like to check in with @samreid to see what else we may need to do for this one.

zepumph commented 13 minutes ago

I'm a liar! We got the tsconfig stuff working well, but we still need to work out lint. For example. We want to make sure that assert isn't an available global (I think that works), but furthermore, we probably want to adapt a system that says "Take all the node rules AND the browser rules", instead of leaving both of them out.