Closed pixelzoom closed 1 year ago
Before I actually do this, since it will be an API change... In https://github.com/phetsims/ph-scale/issues/243, recall that we removed 'name' from SoluteIO, because it's now dynamic. Would you like each Solute's nameProperty
linked back to its corresponding translated string Property?
Here's how the the Studio tree currently looks. The addition would be a *nameProperty
link under each Solute. For example, batteryAcid.nameProperty
would link to phScale.general.model.strings.phScale.choice.batteryAcidStringProperty
.
Great question @pixelzoom. If I remember correctly, global.model.solutes
previously contained the nameProperty
for each solute. Now that solute names are now under general.model.strings
it seems best to link back to the appropriate stringProperty
. Please proceed @pixelzoom.
Done in the above commit, for ph-scale and ph-scale-basics. Screenshot below shows the ph-scale-basics Studio tree.
@arouinfar please review. Feel free to close.
Looks good, thanks @pixelzoom!
Related to https://github.com/phetsims/ph-scale/issues/243 ...
We removed
name
from SoluteIO because name is now dynamic, a Property, and as @samreid said in https://github.com/phetsims/ph-scale/issues/243#issuecomment-1242815159:So when https://github.com/phetsims/axon/issues/414 has been addressed, I will link Solute to its
nameProperty
.