search

phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ph-scale
GNU General Public License v3.0
0 stars 8 forks source link

Support for standard UI sounds #248

Open pixelzoom opened 2 years ago

pixelzoom commented 2 years ago

@kathy-phet requested that I add support for UI sound (the standard common-code sounds) to ph-scale and ph-scale-basics. There will be no custom sounds or sound design.

pixelzoom commented 2 years ago

Standard UI sounds have been added. @arouinfar please review in master.

arouinfar commented 2 years ago

Thanks @pixelzoom. The standard UI sounds all appear as expected.

There will be no custom sounds or sound design.

I'll note that pH Scale: Basics feels a bit odd with just the current UI sounds. The sim has only 6 interactive elements, and of those, only the solute ComboBox and the ResetAllButton have any sound. Since we are working on the alt input patterns for the momentary button (dropper) and FaucetNode, I wonder if we should consider spending time on UI sounds for those components too.

Leaving open and self-assigned to discuss during quarterly planning.

pixelzoom commented 2 years ago

I'll note that pH Scale: Basics feels a bit odd with just the current UI sounds.

I very much agree. And I feel the same way about the first (Macro) screen of pH Scale, not just Basics.

In general, I haven't had a good feeling about adding UI sound to sims where the majority of interaction is with non-standard UI components that have no sound. It's a very odd user experience.

kathy-phet commented 2 years ago

Noted. Sounds like a good thing to discuss re UI sounds. Let's connect with @Ashton-Morris and @jbphet. Could adding some sounds to these kinds of UI elements be part of the upcoming sprint week along with the alt-input work? Momentary button seems reusable?

jbphet commented 2 years ago

Could adding some sounds to these kinds of UI elements be part of the upcoming sprint week...?

No problem for me doing so if that's the priority.

pixelzoom commented 2 years ago

In Slack, @kathy-phet wrote:

I chatted with Amy and we will move forward with pH Scale / pH Scale Basics phet-io. Disable the sounds and make a call on whether to leave the existing keyboard navigation in, but not label it as supported, or just disable it entirely. Amy said it is helpful, even if it isn't perfect. ...

So I've disabled sound by removing `"supportsSound": true" from package.json for ph-scale and ph-scale-basics.

Unassigning this issue and labeling as deferred, to be addressed sometime after 1.6 PhET-iO release.

pixelzoom commented 1 month ago

Since we are proceeding with completion of alt input in #249, it seems appropriate to also revisit UI sound.

Comparing to the state of sound back in 10/2022 (see @arouinfar summary in https://github.com/phetsims/ph-scale/issues/248#issuecomment-1269389701) we now have default sounds for the draggable items (pH probe, chart "indicators") and the faucet. So the sound implementation does feel more complete now.

Sound needs to be addressed for the momentary toggle button on the dropper -- in common code, and requires both design input and a bit of implementation. See https://github.com/phetsims/sun/issues/895 and https://github.com/phetsims/sun/issues/896.

@arouinfar @kathy-phet Your thoughts?