search

phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ph-scale
GNU General Public License v3.0
0 stars 7 forks source link

You cannot set state on a phetioState:false object!! #268

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

This issue is to make sure that whatever work in done in https://github.com/phetsims/phet-io/issues/1903 that should be in ph-scale, gets into it. Marking as blocking. No work to be done until I note it.

pixelzoom commented 1 year ago

The assertion error for this is:

PhetioStateEngine.ts:325 Uncaught Error: Assertion failed: must support phetioState to be set at window.assertions.assertFunction (assert.js:28:13) at PhetioStateEngine.setStateForPhetioObject (PhetioStateEngine.ts:406:15) at PhetioStateEngine.ts:310:14 at Array.forEach () at PhetioStateEngine.iterate (PhetioStateEngine.ts:295:22) at PhetioStateEngine.setState (PhetioStateEngine.ts:253:31) at PhetioStateEngine.setFullState (PhetioStateEngine.ts:269:10) at PhetioEngine.implementation (phetioEngine.ts:1035:65) at PhetioCommandProcessor.processCommand (phetioCommandProcessor.ts:417:51) at getReturn (phetioCommandProcessor.ts:295:36)

And I'm now seeing this in https://github.com/phetsims/ph-scale/issues/271

pixelzoom commented 1 year ago

@zepumph please patch this in ph-scale 1.6 and ph-scale-basics 1.6 when ready.

samreid commented 1 year ago

@zepumph and I cherry picked this, and verified it locally by migrating a state from 1.5 using the version migration wrapper. Nothing more to test that would require QA expertise. @zepumph and I will test again when RC.2 is up.

zepumph commented 1 year ago

This is working great in RC versions. Closing