Customized strings in old studio version applies to active language

phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/ph-scale

GNU General Public License v3.0

0 stars 7 forks source link

Customized strings in old studio version applies to active language #269

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

This issue is to make sure that whatever work in done in https://github.com/phetsims/joist/issues/899 that should be in ph-scale, gets into it. Marking as blocking. No work to be done until I note it.

samreid commented 1 year ago

@zepumph and I cherry-picked this and confirmed it works well. We recommend @Nancy-Salpepi double check it in RC.2 following the directions in https://github.com/phetsims/joist/issues/899

zepumph commented 1 year ago

I confirmed in ph-scale and basics 1.6.0-rc.2 that this is working. Ready for close after QA verification

Nancy-Salpepi commented 1 year ago

Following the steps in https://github.com/phetsims/joist/issues/899, the sim opens in the current language that is set in studio 1.6 instead of the language it was saved in when using version 1.5.