search

phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ph-scale
GNU General Public License v3.0
0 stars 7 forks source link

StateObject validation is not exclusive of extra keys #279

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

For cherry picking https://github.com/phetsims/tandem/issues/290

samreid commented 1 year ago

@zepumph and I cherry-picked this, and confirmed locally by disrupting the NumberIO.step rule in the built rules, and saw that it behaved as expected. We also tried deleting one of the rules that compensates for this, and saw it correctly errored. We will double check in the RC.2. QA expertise not required here.

zepumph commented 1 year ago

This is working well in the version migration wrapper of ph-scale and ph-scale-basics 1.6.0-rc.2:

https://phet-dev.colorado.edu/html/ph-scale/1.6.0-rc.2/phet-io/wrappers/version-migration/?oldVersion=https://phet-io.colorado.edu/sims/ph-scale/1.5/wrappers/studio/ https://phet-dev.colorado.edu/html/ph-scale-basics/1.6.0-rc.2/phet-io/wrappers/version-migration/?oldVersion=https://phet-io.colorado.edu/sims/ph-scale-basics/1.5/wrappers/studio/

Closing