phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ph-scale
GNU General Public License v3.0
0 stars 7 forks source link

Untranslated Azerbaijani Strings #283

Closed solaolateju closed 1 year ago

solaolateju commented 1 year ago

The list of substances in the Azerbaijani translation of the Ph Scale is not showing the translated strings. The translator have noticed this for a few days now but waiting to see if it was a caching issue or just some delay. It seems only the Azerbaijani version is affected. Other locales show the translated strings.

image image
pixelzoom commented 1 year ago

I'm going to assign this to @jbphet and @liammulh (Rosetta subteam) to investigate. First thing would be to determine what the locale code is for Azerbaijani. Then verify that the values for keys with the "choice." prefix are indeed being saved to the Azerbaijani strings file. Perhaps there's a problem with nested keys in Rosetta 2.0.

pixelzoom commented 1 year ago

Azerbaijani locale code is "az".

pixelzoom commented 1 year ago

I verified that babel/ph-scale/ph-scale-strings_az.json does contain entries for the solutes, examples below. I did not inspect the entries futher to see if they are somehow malformed.

"choice.batteryAcid": {
    "value": "Akkumulyator turşusu",
...
  "choice.blood": {
    "value": "Qan",
...
  "choice.chickenSoup": {
    "value": "Toyuq Supu",
pixelzoom commented 1 year ago

Running the sim from the PhET website via https://phet.colorado.edu/sims/html/ph-scale/latest/ph-scale_az.html, I see the reported problem, screenshot below. I have NOT tried to reproduce via master with ?locale=az.

screenshot_2487
liammulh commented 1 year ago

I triggered a rebuild for ph-scale/az: https://phet.colorado.edu/sims/html/ph-scale/1.6.2/ph-scale_az.html, https://phet.colorado.edu/sims/html/ph-scale/latest/ph-scale_az.html.

I believe the strings that were missing are now present.

pixelzoom commented 1 year ago

Thanks @liammulh. The version on the PhET website at https://phet.colorado.edu/sims/html/ph-scale/latest/ph-scale_az.html now looks correct, screenshot below.

@solaolateju please confirm, and close this issue if it looks OK.

screenshot_2492
solaolateju commented 1 year ago

Thank you @liammulh @pixelzoom. Yes, it's ok. I will now close the issue.