phetsims / ph-scale

"pH Scale" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/ph-scale
GNU General Public License v3.0
0 stars 7 forks source link

Migrate overrides.js into code #284

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

... before republishing this sim.

ph-scale-overrides.js and ph-scale-basics-overrides.js must be addressed at the same time.

pixelzoom commented 1 year ago

Baseline versions published before making changes:

pixelzoom commented 1 year ago

My strategy for this migration was to do the macroScreen elements first. They made up the entire contents of ph-scale-basics-overrides.js, and they were repeated in ph-scale-overrides.js. That was done in the above commits, and ph-scale-basics-overrides.js is now empty.

pixelzoom commented 1 year ago

Migration of metadata for model elements was completed in the above commits.

pixelzoom commented 1 year ago

Migration is complete. Time was 1 hour. There were no API changes, and no bugs encountered in the overrides.js file.

Deployed after migration:

Closing