search

phetsims / phet-core

Core utilities used by all PhET simulations.
MIT License
8 stars 6 forks source link

CT merge test multiple objects failed and merge minor change failed #57

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago 
phet-core : top-level-unit-tests : require.js
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553063308813:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553063308813:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553068079677:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553068079677:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553092343864:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553092343864:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553060078583:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553060078583:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553079177258:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553079177258:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553090844769:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553090844769:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553064685287:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553064685287:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553080345787:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553080345787:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553091255596:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553091255596:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea&brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553063270521:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553063270521:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea&brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553078452047:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553078452047:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
phet-core : top-level-unit-tests : require.js?ea&brand=phet-io
30 out of 32 tests passed. 2 failed.
merge: test multiple objects failed:
merge should properly combine multiple objects
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553085011887:164:12)

merge: minor change failed:
time shouldnt leak over to a
    at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1553056978109/phet-core/js/mergeTests.js?bust=1553085011887:310:12)

id: Bayes Chrome
Approximately 3/19/2019, 10:42:58 PM
jessegreenberg commented 5 years ago

Thanks for making an issue @KatieWoe. I think @mbarlow12 was working on merge so I am going to send this his way, but let me know if I can help.

mbarlow12 commented 5 years ago

Just pushed the fix; removed the failing test while we're sorting out how merge is going to work.

KatieWoe commented 5 years ago

Looks good. Closing