search

phetsims / phet-core

Core utilities used by all PhET simulations.
MIT License
8 stars 6 forks source link

mergeTest.js introduces a dependency on axon in phet-core #58

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

Related to https://github.com/phetsims/phet-info/issues/91, the creation of merge.js.

While working on another issue, I noticed that mergeTest.js contains a dependency on axon:

9   var Property = require( 'AXON/Property' );

I believe that it's generally problematic for phet-core to dependent on axon (circular dependency?) And all other require statements in phet-core .js files uses PhET_CORE exclusively. Perhaps this constraint doesn't need to apply to unit tests, but I thought I'd mention it.

mbarlow12 commented 5 years ago

Thanks for spotting this; I'll update the tests to use object literals instead as that will be more generic. The recent changes to merge on Fri. appear to allow for that.

ariel-phet commented 5 years ago

Since Michael has now moved on, reassigning to @pixelzoom to see if this can be closed.

pixelzoom commented 5 years ago

Looks good, closing.