namespacing of inner classes

[pixelzoom]

This issue captures decisions related to our 4/15/19 discussion of the Namespace pattern in phet-software-design-patterns.md, led by @jonathanolson.

"Class" herein means classes and types.

Decisions:

• Namespacing of inner classes is no longer required. @pixelzoom will update code-review checklist if needed.
• Existing namespacing of inner classes will be removed, so that it doesn't look like a convention. To be handled by @pixelzoom, since most usages are his. (Regex search for \.register\( '\w+\.\w)
• If you need to namespacing an inner type/class (e.g. for console debugging), then use register method with a key of the form '{{OUTER_CLASS_NAME}}.{{INNER_CLASS_NAME}}. Hypothetical example:

const myNamespace = require(...);

class SlotMachineNode extends Node {
  constructor( ... ) {
    this.leverNode = new LeverNode(...);
    ...
  }
 ...
}

myNamespace.register( 'SlotMachineNode', SlotMachineNode );

class LeverNode extends Node { 
 ...
}

myNamespace.register( 'SlotMachineNode. LeverNode', LeverNode );

return SlotMachineNode;

Tasks:

• [x] update code_review_checklist.md
• [x] remove existing namespacing of inner classes

[pixelzoom]

Done, closing.