search

phetsims / phet-lib

Contains built versions of PhET common code libraries
MIT License
1 stars 0 forks source link

Layout Exemplar documentation broken by stepEmitter/clock refactor #2

Closed jonathanolson closed 7 months ago

jonathanolson commented 7 months ago

Not working after https://github.com/phetsims/phet-lib/commit/7b8feca8a8630f7249617bb8e06aa8aa78d8f3d2.

I'm going to revert the commit, but thoughts on if I'm missing anything?

jonathanolson commented 7 months ago

Animation doc change was also incorrect, patched above.

jonathanolson commented 7 months ago

@pixelzoom can you review the revert commits above (and the original commits) to make sure this is all ok? layout exemplars (in phet-lib), layout docs (in scenery) were broken, and other documentation looked incorrect.

pixelzoom commented 7 months ago

Sorry about that -- I didn't notice that WebStorm used a wider scope for my rename in FEL. Everything looks OK now.