search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
5 stars 7 forks source link

QA credits were not updated for 1.1 release #101

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

1.1.0 was published (see https://github.com/phetsims/plinko-probability/issues/100) without updating the QA credits. There are testers in the test matrix that are not identified in the credits. Get the updates from @phet-steele, commit them to 1.1 and master branches, then publish maintenance release 1.1.1.

zepumph commented 7 years ago

Shoot dang, I had no idea that I needed to do this. Where is this documented? I'm not seeing it in sim_deployment.md, but also I could have missed it.

pixelzoom commented 7 years ago

Also commit them to the 1.1-phetio branch.

No idea if it's documented anywhere. I always create an "update QA credits" issue when I start the QA process.

zepumph commented 7 years ago

I added the credits to branches: master, 1.1, and 1.1-phetio. They will be updated on next Maintenance release. This will be picked up in https://github.com/phetsims/QA/issues/2. Closing