search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

On the first screen, you cannot unselect "×100" #109

Open samreid opened 6 years ago

samreid commented 6 years ago

Once you have pressed "x All" and "Play", there is no way to stop it (aside from a reset). You can even change the radio button values to "x 10" and "x 1" but they keep coming. Is this the desired behavior?

Discovered in https://github.com/phetsims/sun/issues/360

Assigned to @pixelzoom since he is listed as the responsible dev, and I'm not sure who the design team is.

pixelzoom commented 6 years ago

That sure seems buggy to me. The Flash version has radio buttons for '1 ball' and 'continuous', changing the selection from 'continuos' to '1 ball' stops the flow of balls, and you have to press 'Start' to resume. The HTML5 version has 'x 1', 'x 10' and 'x All', and I would expect similar behavior -- the flow of balls should stop whenever the radio button changes, and you have to push "Play" to start the flow.

Assigning to @amanda-phet since she's the designated designer.

samreid commented 6 years ago

I should note this problem is observed in master and in the version published on the website, which is 1.1.3

amanda-phet commented 6 years ago

"x All" is supposed to indicate that you are dropping ALL 100 balls.

I could see changing this to a pause button when that happens, so you have the option to pause what is happening. I would also be fine with this stopping when you change radio buttons, but would this also change the interaction if "x 10" is selected? If you press play and change your mind, can you also abort the (10-n) remaining balls from falling?

pixelzoom commented 6 years ago

"x All" is supposed to indicate that you are dropping ALL 100 balls.

I don't think there's any question about that. The question is what happens if they change the selection to something else before all 100 balls have dropped. Either the radio buttons should be disabled until all 100 balls are dropped (which I'm not recommending) or "drop all 100 balls" should be stopped when the radio button select is changed (which I'm recommending).

The Flash version stops the 'continuous' flow of balls if the radio button selection is changed. And yes, '×10' and '×All' would behave the same. If you change the selection, the action associated with your previous selection should stop.

amanda-phet commented 6 years ago

That interaction pattern seems logical to me. I'm happy with that change.

pixelzoom commented 6 years ago

OK, I will proceed with what I proposed.

pixelzoom commented 6 years ago

@amanda-phet

Do you want an immediate maintenance release for this issue? It will require an addition 30-60 minutes.

Or do you want to wait until the next time the sim is published from master? There is currently no timeframe for publishing from master, and it will require a full QA cycle.

pixelzoom commented 6 years ago

Discussed with @amanda-phet. This sim has had some a11y work and will probably be published out of master for that. So no maintenance release, wait until published out of master for a11y.

pixelzoom commented 6 years ago

On Slack, @amanda-phet indicated that she wanted to discuss how this fix should be published with @ariel-phet. So assigning to @amanda-phet.

pixelzoom commented 6 years ago

Note that 'x All' was changed to 'x 100' in #110.

pixelzoom commented 6 years ago

This has been addressed in master, @amanda-phet please verify. When the radio button selection is changed, any balls that have not yet been released from the hopper are canceled, and the enabled state of the "Play" button is adjusted accordingly.

pixelzoom commented 5 years ago

@amanda-phet you could also verify this in 1.2.0-dev.4.

amanda-phet commented 5 years ago

Looks like it's working as expected.