phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

Peg rotated too far at min/max binary probability #18

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

@amanda-phet @veillette I couldn't find anywhere in the design doc that explicitly states this, but in the Flash version of the sim, the flat part of a peg at min/max binary probability is only rotated ~45 degrees: screen shot 2016-06-02 at 10 08 48 am The new sim rotates twice that to ~90 degrees. It would make more sense to match the Flash version in this case, otherwise the ball is still hitting a rounded peg when falling from the top. screen shot 2016-06-02 at 10 02 33 am

For phetsims/tasks/issues/608

veillette commented 8 years ago

image

We can change it to something along the previous image if you prefer.

veillette commented 8 years ago

here is the commit https://github.com/phetsims/plinko-probability/commit/d9aca1ccf5f52a254b49110b918ec0743bd51a31

phet-steele commented 8 years ago

@veillette this looks good.