phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

User can't easily add more balls after max count of 9999 #19

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

@amanda-phet @veillette In the Lab screen, after reaching the max bin count of 9999, a user should be able to add more balls after changing the number of rows or the value of binary probability. Changing either of those variables returns N to 0 in the same way the Erase button or Reset All button would, except hitting play will only prompt the "Out of Balls" dialogue. Seen on numerous platforms.

pp01

For phetsims/tasks/issues/608.

memo330179 commented 8 years ago

That should fix it. Assigning to @veillette for review.

veillette commented 8 years ago

assigning to @alynne-phet for review

alynne-phet commented 8 years ago

@veillette The simulation does not stop at the max bin count of 9999. Has this been changed so there is no max bin count? I have been able to add over 9999 balls. Also, when using the query parameter 'lowerBallMaximum,' 100 balls fell before reaching the max bin count. Would you like me to create a new issue for this?

When the max bin count is reached on the 'lowerBallMaximum' query parameter this issue is fixed. Balls can be added after changing the number of rows or the value of binary probability.

veillette commented 8 years ago

@alynne-phet

One clarification: For the second tab, the number of balls can exceed 9999. However you should not be able to get the number of balls per bins to exceed 9999. When it is about to exceed this number, a dialog box should appear.

It takes a lot of time to reach that number,but the query parameter lowerBallMaximum makes it more amenable to testing.

On the first screen the max number refers to the total number of balls that lands.

alynne-phet commented 8 years ago

@veillette This makes much more sense. This issue has been fixed!

veillette commented 8 years ago

Thanks. Closing this issue.