search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

Long string issues #29

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

For stringTest=long, there is some text that extends into other elements on screen.

For the radio button text in the lab screen, I can imagine that text could reach the control panel: string2

For the intro screen, it does seem unlikely that the strings would get long enough to hit the board, but please limit the length just in case. string1

Denz1994 commented 8 years ago

I limited the maxWidth of the text nodes in the panels and now they scale the text size, with respect to an elongated text. The vertical radio button text no longer overlaps with the play button panel as well. Assigning to @jessegreenberg for review.

jessegreenberg commented 8 years ago

Great, thanks @Denz1994. Closing.