missing assets directory

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 7 forks source link

missing assets directory #30

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

The assets directory is missing for this sim. assets should contain the original files used to create images, audio, etc. For example, the file used to create images/container.png should be in assets/.

veillette commented 8 years ago

The directory was created

We have seven png images checked in.

[x] container
[x] counter
[x] fraction
[x] intro-homescreen-icon
[x] intro-navbar-icon
[x] lab-homescreen-icon
[x] lab-navbar-icon

We would need the .ai files to be checked in the asset directory

We also have two sounds

[ ] bonk-1-for-plinko
[ ] bonk-2-for-plinko

We would like to get the .wav files checked in the asset directory

The images were created by @amanda-phet whereas the sounds were created to @jbphet .

Assigning first to @amanda-phet to check in the .ai files into the asset directory.

veillette commented 8 years ago

@amanda-phet: I believe that it is now possible to upload binary files directly into GitHub from the web interface. If you run into any difficulties, you can email me the files instead.

amanda-phet commented 8 years ago

@jbphet do you have the sound files to upload?

jbphet commented 8 years ago

I used a program called "Propellerhead Reason" to generate the sounds. I could upload the file, but it doesn't seem very worthwhile, since it isn't a program that anyone else is likely to have and thus couldn't edit it. We should discuss in developer meeting whether such files should be stored in assets.

samreid commented 8 years ago

Meeting July 21, 2016: Everyone agrees we should check in the original asset files, including full resolution wave files, propellerhead files, etc. If you wrote code to generate the audio, the code should be checked in, etc.

andrewadare commented 8 years ago

@jbphet Now that it's been decided to put the audio project files in the repo, can you add the Reason file(s) to assets/ when you get a chance? Thanks!

pixelzoom commented 8 years ago

@jbphet This sim is now in the "home stretch", so please add the assets for the audio files asap. Thanks.

pixelzoom commented 8 years ago

Moved check in of missing audio assets to https://github.com/phetsims/plinko-probability/issues/53. All other assets appear to be present. Closing.