phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

Complete sim credits #32

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

This issue is just to serve as a reminder to complete sim credits before publication.

amanda-phet commented 8 years ago

I will return to these to edit but this is the starting point.

credits: {
  leadDesign: 'Michael Dubson, Amanda McGarry',
  softwareDevelopment: 'Martin Veillette',
  team: 'Karina K. R. Hensberry, Trish Loeblein, Ariel Paul, Kathy Perkins',
  qualityAssurance: '',
  graphicArts: '',
  thanks: ''
}
veillette commented 8 years ago

This is what I have so far

      leadDesign: 'Michael Dubson, Amanda McGarry',
      softwareDevelopment: 'Denzell Barnett, Guillermo Ramos-Macias, Martin Veillette',
      team: 'Karina K. Hensberry, Trish Loeblein, Ariel Paul, Kathy Perkins',
      qualityAssurance: 'Ben Roberts, Steele Dalton, Amanda Davis'
pixelzoom commented 8 years ago

This sim is now in the "home stretch" so we need to wrap up this issue. @amanda-phet Assigning this to you, since you're the lead. Please specify any changes that need to be made.

Here's what the credits currently look like in plinko-probability-main.js:

  var simOptions = {
    credits: {
      leadDesign: 'Michael Dubson, Amanda McGarry',
      softwareDevelopment: 'Denzell Barnett, Guillermo Ramos-Macias, Martin Veillette',
      team: 'Karina K. Hensberry, Trish Loeblein, Ariel Paul, Kathy Perkins',
      qualityAssurance: 'Ben Roberts, Steele Dalton, Amanda Davis'
    }
  };

And in the About dialog:

screenshot_97

phet-steele commented 8 years ago

@pixelzoom QA credits are correct, but not alphabetical by last name. That's the only thing that needs changing in QA.

pixelzoom commented 8 years ago

QA names have been alphebetized.

pixelzoom commented 8 years ago

I moved @veillette to the front of the "Software Development" list, since he clearly did the bulk of the work. And I added myself. Here's the latest About dialog:

screenshot_102

amanda-phet commented 8 years ago

I don't think there are any changes to make here.