search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

Exceeding max bin count #34

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

@veillette not sure if this is a result from the fix for #27 or not, but it's possible for me to go one ball over the max bin count by doing this:

(These steps are reversible)

  1. On the Lab screen, keep the ball dropping method to "single"
  2. Click play enough times to get just one away from the max (24 or 9998)
  3. If you were using the "Ball" option, switch to "None". If you were using the "None" option, switch to "Ball"
  4. You can now click the play button twice and reach 26 or 10000

This was tested on master at 11:30 AM on 7/1 with OSX 10.11.5 Chrome. There was some way I managed to reach 27 (10001) by some combination of switching between radio buttons, but I can't remember how. pp03

memo330179 commented 8 years ago

We are now only removing the balls that have not landed or exited the peg board. This takes care of #27 as well.

memo330179 commented 8 years ago

assigning to @phet-steele for review. You can test this out on master.

phet-steele commented 8 years ago

@memo330179 looks good to me, thanks