search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

rename PlinkoConstants? #59

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

The usual convention would be to name this either PlinkoProbabilityConstants or PPConstants. Other types use the "PlinkoProbability" prefix (e.g. PlinkoProbabilityQueryParameters, PlinkoProbabilityCommonView, PlinkoProbabilityCommonModel).

I don't feel too strongly about which way to go. But PlinkoProbabilityConstants is going to result in some very long lines at the sites where the constants are used.

veillette commented 8 years ago

I don't have a strong opinion about it.

pixelzoom commented 8 years ago

I renamed PlinkoConstants to PlinkoProbabilityConstants. But I'm not going to inspect all 156 usages to check for lines that have gotten too long. We'll address those as we encounter them during ongoing development and maintenance.