search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 7 forks source link

use ShadedSphereNode for balls #64

Closed pixelzoom closed 7 years ago

pixelzoom commented 8 years ago

BallNode (used to render the balls) is basically an implementation of a shaded sphere, with a specular highlight. PhET already has something like this in common code, scenery-phet.ShadedSphereNode, and it should be used here.

pixelzoom commented 8 years ago

Done.

This does change the look a bit, so I'd like @amanda-phet and @ariel-phet to verify. Before and after screenshots shown below. The "After" look is now consistent with the look in other PhET sims (light source at upper left).

Before:

screenshot_106

After:

screenshot_107

pixelzoom commented 8 years ago

Btw... I can also reproduce the original look, if you'd prefer.

ariel-phet commented 8 years ago

Mind publishing a new dev version so I can view on iPad?

pixelzoom commented 8 years ago

http://www.colorado.edu/physics/phet/dev/html/plinko-probability/1.0.0-dev.9/plinko-probability_en.html

amanda-phet commented 8 years ago

I think it looks fine but I'll want to update the artwork for the screen icons to match the new ball appearance.

pixelzoom commented 8 years ago

Or I can adjust the implementation to match the artwork? Note that the artwork and implementation didn't match exactly previously -- specular highlight was a little off.

ariel-phet commented 8 years ago

Looks fine to me, but defer to @amanda-phet for particular look

amanda-phet commented 7 years ago

Let's use ShadedSphereNode, but I'll send you new artwork for the screen icons and scene selection icon that match slightly better.

For example: screen shot 2016-08-31 at 12 13 28 pm

pixelzoom commented 7 years ago

@amanda-phet Sounds good. The .ai (asset) files that you'll need to update are:

https://github.com/phetsims/plinko-probability/blob/master/assets/plinko-screen-icons.ai https://github.com/phetsims/plinko-probability/blob/master/assets/cylinder.ai

I can create the .png files from the .ai files.

amanda-phet commented 7 years ago

I updated the .ai assets so they should be good to go.

pixelzoom commented 7 years ago

@amanda-phet Please review this dev version. If it looks OK, you can close this issue.

http://www.colorado.edu/physics/phet/dev/html/plinko-probability/1.0.0-dev.10/plinko-probability_en.html

amanda-phet commented 7 years ago

Looks great. Thanks!