search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
5 stars 7 forks source link

use PlayPauseButton #73

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

This sim has is own PlayButton and PauseButton. Why isn't is using the common-code button scenery-phet.PlayPauseButton?

pixelzoom commented 7 years ago

The current buttons in this sim look like this (currently flat, but could be 3D):

screenshot_04 screenshot_05

scenery-phet.PlayPauseButton has a different look:

screenshot_06 screenshot_07

And I'm not sure if the play and pause states can have different colors.

@ariel-phet Do you want me to investigate this, or leave as is?

pixelzoom commented 7 years ago

PlayButton is 56 lines of code. PauseButton is 58 lines of code.

Not a huge savings here by switching to PlayPauseButton, just the consistency of using common code.

pixelzoom commented 7 years ago

RoundButtonView has a setter for baseColor, so likely that the play and pause states could have different colors.

amanda-phet commented 7 years ago

I would prefer the common code button but with different colors. The green button was effective in interviews and I don't think the light blue would be bold enough.

ariel-phet commented 7 years ago

@pixelzoom agree with @amanda-phet

pixelzoom commented 7 years ago

OK, I will investigate using PlayPauseButton.

pixelzoom commented 7 years ago

Investigated and decided that this is not worth the trouble. On the "Intro" screen, there is no pause button, so it's not easy to use PlayPauseButton, we'd still need PlayButton. So I'll give PlayButton and PauseButton a quick cleanup, then close this issue.

pixelzoom commented 7 years ago

Cleanup completed, closing.

pixelzoom commented 7 years ago

Also identified a more efficient way of implementing the pause icon in PlayPauseButton, tracking in https://github.com/phetsims/scenery-phet/issues/268.