search

phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
5 stars 7 forks source link

HistogramNode doesn't require access to the entire model #78

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Current constructor signature is:

function HistogramNode( histogramModeProperty, model, modelViewTransform, isTheoreticalHistogramVisibleProperty )

But it needs access to only 2 of the 9 public model fields:

model.histogram model.numberOfRowsProperty

pixelzoom commented 7 years ago

Never mind. Inner type HistogramBarNode accesses other things in the model -- some of which seem like they should be part of the Histogram model element. But there's way too much here to attempt to untangle.

Closing.