phetsims / plinko-probability

"Plinko Probability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
5 stars 7 forks source link

inconsistent field names in cylinderInfo data structure #91

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

IntroModel defines this data structure that describes the bins (cylinders):

    this.cylinderInfo = { // @public (read-only)
      height: bounds.height * 0.87, // we want the cylinders to be shorter than the histogram
      cylinderWidth: cylinderWidth,
      ellipseHeight: ellipseHeight, // the height of the ellipse
      verticalOffset: 0.035, // gap between pegboard and cylinders
      top: bounds.maxY // the top of the cylinders
    };

Very inconsistent to have cylinderWidth and height. Recommended to rename height to cylinderHeight.

pixelzoom commented 7 years ago

Not a prerequisite for 1.0.0 publication.

pixelzoom commented 7 years ago

I'll probably knock this one off immediately after publishing 1.0.0.

pixelzoom commented 7 years ago

1.0.0 has been published, so this can now be addressed.