Closed amanda-phet closed 7 years ago
The peg seems pretty small. Are you sure that is the size at 3 rows? It looks like the size at 4 rows, to my eye.
Perhaps we should just focus on the 1-row case. This is the mockup from April. Can get close to this size for 1 row, and see how the others scale after that? I'm not sure what kind of scaling logic you are using, though.
@amanda-phet: Row 1 and 2 are essentially custom made so we can adjust the radius of the balls, the radius of the pegs and the the vertical offset of the pegs easily. I'll use your screenshot from row 1 and adjust row 2 accordingly.
That sounds great.
@amanda-phet , based on your screenshort, I rebased the scale of the balls as well.
The pegs are rescaled according to be inversely proportional to the number of bins rather than the number of rows The pegs size is proportional to 1/(rows+1). This affects the scaling for all rows but is is hard noticeable for larger number or rows, but it makes a larger difference when the number of rows is small.
Currently for rows 3-26, the balls are bigger than the pegs, but for rows 1 and 2 and three the balls are scaled down. For Row=1, the ball size is reduced by 75% of what is would be according to our simple scaling, For Row=2, the ball size is reduced by 80% of what is would be according to our simple scaling, For Row=3, the ball size is reduced by 86% of what is would be according to our simple scaling,
For row four and above it follow the simple scaling rule.
I have included screenshots above.
It looks great to me!
Thank @amanda-phet. Closing this issue.
When there are only 3 or 4 rows of pegs, the size of the pegs and balls looks good to me.
However, at 1 and 2 rows, the peg seems unusually large.
![1-row 1](https://cloud.githubusercontent.com/assets/7852916/26801554/76e34542-49fa-11e7-8b19-f1176328a168.png)
I think the peg needs to max out at a certain size. Can you make the peg size for 1-2 rows match the peg size at 3 rows? So, the peg would not grow in size below 3 rows of pegs.