phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Landed projectiles have inconsistent opacity #128

Closed catherinecarter closed 7 months ago

catherinecarter commented 7 months ago

Playing with the sim, I noticed the cannonballs are much more transparent (maybe grey?) than the piano:

image

With all 3 types together: image

Curious if we should consider making the opacity upon landing consistent?

samreid commented 7 months ago

Working copy patch:

image

samreid commented 7 months ago

@matthew-blackman will adjust the colors separately.

matthew-blackman commented 7 months ago

I rebalanced the levels on the piano image to make it more clear that it was deselected. I think this is a good balance of saturation/brightness. I don't want to make the projectiles too washed out, to avoid the field looking like a gray blob when there are different types of landed projectiles. @catherinecarter can you review?

catherinecarter commented 7 months ago

It's better, but I still think the cannonballs are more muted than the other projectiles: image

The difference between a landed and focused projectile is much more stark for the cannonballs, or maybe it's that the you can tell the pumpkin and piano are still their color, but the light is not shining on them as much, where the cannonball looks like there's a fog over it instead of a light just not making it as bright. Maybe a combination of both. Not sure, but the cannonball looks different. image image image

Would it be strange to have a non-black piano?

matthew-blackman commented 7 months ago

Sounds good @catherinecarter! I updated the cannonball images so that the selected one looks highlighted instead of darkened. It's definitely an improvement. Can you take a look?

catherinecarter commented 7 months ago

Looks much better, I agree!

One thing to note is that the pumpkin is a little dark on field 6 compared to field 1:

image image

Not sure it's worth being a concern, but wanted to bring it up in case others felt the same way. But the cannonballs look much better.

I still think considering a different color for the piano would be worth exploring, since the two black objects get lost in each other:

image
matthew-blackman commented 7 months ago

Sounds good @catherinecarter! I hear what you're saying. I'd like to keep it for now and see where we land on the projectile types. Reworking the piano graphics beyond an overall color filter would be a fair amount of work, but I agree that there is still room for improvement. Let's close this issue and decide if we want to open a separate graphics issue for the projectile images.

matthew-blackman commented 7 months ago

Reopening to share updated cannonball artwork from design meeting with @ariel-phet. Updating the cannonballs to a more 'steel' looking design provided good contrast with the pianos, and looked good on all field backgrounds. @catherinecarter can you weigh in? Feel free to re-close if all looks good here.

matthew-blackman commented 7 months ago

@catherinecarter, @samreid and I made some additional improvements to the cannonball selected image. Things are looking much better, and all projectile types are distinguishable from one another in both landed and selected states. Nice work! This issue can be closed.