search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

`stopwatchNode.visibleProperty` should be derived from state of checkbox #151

Closed arouinfar closed 7 months ago

arouinfar commented 7 months ago

@matthew-blackman @samreid while reviewing the tree for #29, I noticed that the StopwatchNode has a visibleProperty that behaves independently of the Stopwatch checkbox (model.stopwatch.isVisibleProperty).

Notice the stopwatch is visible, but the checkbox is not checked: image

The tree currently looks like this: image

Instead of view.stopwatchNode.visibleProperty I would expect to see *visibleProperty link to model.stopwatch.isVisibleProperty, similar to how we do things for the MeasuringTapeNode: image

samreid commented 7 months ago

Good idea, thanks! Fixed, pushed and closing.