search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Histogram sound should not stop when adjusting zoomProperty #166

Closed matthew-blackman closed 6 months ago

matthew-blackman commented 6 months ago

Zooming in and out of the histogram should not stop the histogram sound sequence. This is coming from updateHistogram being called in the histogram.zoomProperty.link on HistogramNode. Let's find a way to tell the HistogramSonifier not to stop the sound in this case.

samreid commented 6 months ago

Proposed fix in the commit. I analyzed all the calls to updateHistogram and saw one other that likely shouldn't cancel the sonification. Ready for review.

matthew-blackman commented 6 months ago

This is fixed by the above commit. Reviewing this with @samreid, we opted not to stop the histogram sound when navigating data or samples. That work snuck in to #169 in this commit. Sorry about that!

The behavior is correct on all screens, and the code has been reviewed and looks good. Nice work! Closing.