Don't enable histogram sound button in Sampling-Continuous

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Don't enable histogram sound button in Sampling-Continuous #181

Closed matthew-blackman closed 6 months ago

matthew-blackman commented 6 months ago

@Nancy-Salpepi noticed that the histogram sound button becomes enabled on the Sampling screen when switching to Continuous mode, even if there is no data. This is a bug. Let's fix it!

samreid commented 6 months ago

I committed a proposed fix. @matthew-blackman can you please review and test?

matthew-blackman commented 6 months ago

Your solution worked for me @samreid but required adding a property to the multilink. I committed a proposed solution that I believe will also work but not require an additional dependency. Can you spot check?

samreid commented 6 months ago

The proposal looks preferable and is testing well on my side, thanks. Closing.