search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Sampling screen fails to show a dot on the selected sample during autogenerate #182

Closed samreid closed 6 months ago

samreid commented 6 months ago

@catherinecarter said in https://github.com/phetsims/projectile-data-lab/issues/146#issuecomment-1960203626

One thing I just noticed while playing with it (I love it, by the way) is that on the VSM screens, there's a white dot to indicate the last projectile launched. The dot matches the circled value on the field.

On the Sampling screen, there's currently no dot to indicate the last mean generated, and I'd love it if that dot could be there. It would help make the connection that the mean value is the thing being graphed since the value above the mean triangle would match the white dot in the histogram.

samreid commented 6 months ago

I think this wasn't working this morning, but it seems to be working now. @matthew-blackman can you please confirm?

samreid commented 6 months ago

@catherinecarter clarified this is only during "autogenerate"

samreid commented 6 months ago

Also, autogenerate data then pressing the "decrement" button in the sample selector, reduces the total number from 200 to 199 and a histogram brick disappears. This is likely related.

samreid commented 6 months ago

@matthew-blackman and I corrected this in the commit, closing.