search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Inspect/confirm/update phase logic for data autogeneration when launch button pressed #193

Closed samreid closed 6 months ago

samreid commented 6 months ago

From #146, there was this todo:

  public override launchButtonPressed(): void {

    const field = this.fieldProperty.value;
    const phaseProperty = field.phaseProperty;

    // Regenerate data if set for autogeneration
    if ( AUTO_GENERATE_DATA_PROPERTY.value ) {

      field.clearProjectiles();

      // TODO: These should be investigated: https://github.com/phetsims/projectile-data-lab/issues/146
      field.phaseProperty.value = 'showingCompleteSampleWithMean';
      field.isContinuousLaunchingProperty.value = true;
samreid commented 6 months ago

@matthew-blackman and I fixed this, closing.