Closed pixelzoom closed 5 months ago
package.json eslintConfig currently looks like this:
"eslintConfig": {
"extends": "../chipper/eslint/sim_eslintrc.js",
"overrides": [
{
"files": [
"**/*.ts"
],
"rules": {
"@typescript-eslint/ban-ts-comment": [
"error",
{
"ts-expect-error": true,
"ts-ignore": true,
"ts-check": true,
"ts-nocheck": true
}
],
"no-object-spread-on-non-literals": "error",
"additional-bad-text": [
"error",
{
"forbiddenTextObjects": [
"dispose"
]
}
],
"author-annotation": "error"
}
}
]
}
What do you recommend we change?
(oops, accidentally pressed close. Reopened).
I said it should be reviewed and cleaned up. For example, "no-object-spread-on-non-literals": "error"
and "author-annotation": "error"
are both unnecessary, because they are the defaults in chipper's .eslintrc.js.
Thanks! I checked each entry and saw that the two you mentioned are unnecessary. The other ones seem necessary. So I removed the redundant ones. Closing.
Related to code review #32 ...
From the CRC:
eslintConfig
looks like it needs some cleanup, sometime before the sim is published.