search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Dynamic layout issues #204

Closed pixelzoom closed 5 months ago

pixelzoom commented 5 months ago

For code review #32, CRC item:

  • [ ] Does the sim behave correctly with dynamic layout, to support dynamic locale? Run with stringTest=dynamic and use the left/right arrow keys.

Overall the sim looks great. But I did find 3 problems.

(1) In the Histogram, the "Bin width" ComboBox overlaps the "Distance" x-axis label:

screenshot_3058

(2) In the field display, "No data" does not remain centered:

screenshot_3060

(3) In TimeControlNode, both the text and the radio buttons are scaled down. Only the text should scale; the radio buttons should not change size. The buttons should also remain vertically centered on the play/pause button. This is likely a problem in TimeControlNode, and a fix would benefit all sims.

screenshot_3059
samreid commented 5 months ago

I fixed the histogram overlap.

(2) In the field display, "No data" does not remain centered:

This one is only a problem in the Sampling screen. I could use @matthew-blackman help on that layout.

I wonder if the TimeControlNode issue is related to https://github.com/phetsims/scenery-phet/issues/826 which @marlitas was asking about.

matthew-blackman commented 5 months ago

Self-assigning to work on the Sampling field sign.

samreid commented 5 months ago

The proposed commit fixes the problem in my testing. @matthew-blackman can you please test? Feel free to close if the behavior is correct.

matthew-blackman commented 5 months ago

@samreid and I reviewed the changes here and everything looks great. Tested and all known layout issues are fixed. Nice work! Closing.