Closed pixelzoom closed 5 months ago
This was addressed in commit https://github.com/phetsims/projectile-data-lab/commit/d9ed4efe64718c604f2dcc39e2df08acc99ea6bb. Not sure why it's not linking over here. Thanks for the suggestion @pixelzoom, this looks much cleaner. Changes were straightforward. Closing.
For code review #32 ...
The names of
SectionLauncherConfiguration
,SectionMysteryLauncher
, andSectionProjectileType
are a little odd. They all extendPDLPanelSection
, so they would typically be namedSomethingSection
orSomethingPanelSection
.Use sites are also a little odd, where
const
names do not match class names (same words, but different order). E.g.:Consider renaming to
LauncherConfigurationSection
, etc. where the word "Section" is last. This would match the superclass name and theconst
instance names. E.g.: